Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logging for failed JSON serialization #1473

Merged
merged 7 commits into from
Feb 7, 2022

Conversation

SimonCropp
Copy link
Contributor

fixes #1218

@getsentry getsentry deleted a comment from github-actions bot Feb 7, 2022
Copy link
Collaborator

@lucas-zimerman lucas-zimerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments but looks good for merging.

Co-authored-by: LucasZF <lucas-zimerman1@hotmail.com>
@getsentry getsentry deleted a comment from codecov-commenter Feb 7, 2022
@SimonCropp SimonCropp merged commit fba1728 into main Feb 7, 2022
@SimonCropp SimonCropp deleted the Improve-logging-for-failed-JSON-serialization branch February 7, 2022 19:10
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- Improve logging for failed JSON serialization ([#1473](https://github.com/getsentry/sentry-dotnet/pull/1473))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against adb11e0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging for failed JSON serialization
3 participants