Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect sdk name in envelope header #1474

Merged
merged 6 commits into from
Feb 7, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Feb 7, 2022

fixes #1219

Sentry.Reflection.AssemblyExtensions is also obsoleted.

@SimonCropp SimonCropp changed the title Envelope header has incorrect sdk name Fix incorrect sdk name in envelope header Feb 7, 2022
@getsentry getsentry deleted a comment from github-actions bot Feb 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #1474 (d6444db) into main (8b4d317) will decrease coverage by 0.00%.
The diff coverage is 95.45%.

❗ Current head d6444db differs from pull request most recent head 63bbd9d. Consider uploading reports for the commit 63bbd9d to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1474      +/-   ##
==========================================
- Coverage   84.23%   84.22%   -0.01%     
==========================================
  Files         219      219              
  Lines        7383     7392       +9     
  Branches     1415     1416       +1     
==========================================
+ Hits         6219     6226       +7     
  Misses        728      728              
- Partials      436      438       +2     
Impacted Files Coverage Δ
src/Sentry/Reflection/AssemblyExtensions.cs 76.92% <88.88%> (+10.25%) ⬆️
src/Sentry/Internal/ApplicationVersionLocator.cs 81.81% <100.00%> (+1.81%) ⬆️
src/Sentry/Internal/MainSentryEventProcessor.cs 97.34% <100.00%> (ø)
src/Sentry/SdkVersion.cs 100.00% <100.00%> (ø)
src/Sentry/Internal/MonoSentryStackTraceFactory.cs 92.59% <0.00%> (-3.71%) ⬇️
src/Sentry/Internal/BackgroundWorker.cs 91.30% <0.00%> (-0.73%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b4d317...63bbd9d. Read the comment docs.

@SimonCropp SimonCropp merged commit 945c3d9 into main Feb 7, 2022
@SimonCropp SimonCropp deleted the Envelope-header-has-incorrect-SDK-name branch February 7, 2022 19:12
@github-actions
Copy link
Contributor

github-actions bot commented Feb 7, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- Fix incorrect sdk name in envelope header ([#1474](https://github.com/getsentry/sentry-dotnet/pull/1474))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against d96ab71

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Envelope header has incorrect SDK name
4 participants