Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treat IO exception as a network issue #1476

Merged
merged 6 commits into from
Feb 7, 2022
Merged

Conversation

SimonCropp
Copy link
Contributor

fixes #1420

@getsentry getsentry deleted a comment from github-actions bot Feb 7, 2022
@getsentry getsentry deleted a comment from codecov-commenter Feb 7, 2022
@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2022

Codecov Report

Merging #1476 (ab5ad18) into main (945c3d9) will decrease coverage by 1.39%.
The diff coverage is 87.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1476      +/-   ##
==========================================
- Coverage   84.27%   82.87%   -1.40%     
==========================================
  Files         219      219              
  Lines        7402     7387      -15     
  Branches     1417     1417              
==========================================
- Hits         6238     6122     -116     
- Misses        730      837     +107     
+ Partials      434      428       -6     
Impacted Files Coverage Δ
src/Sentry/Internal/Http/CachingTransport.cs 82.55% <87.87%> (-0.38%) ⬇️
src/Sentry/PlatformAbstractions/FrameworkInfo.cs 0.00% <0.00%> (-100.00%) ⬇️
...ntry/PlatformAbstractions/RegistryKeyExtensions.cs 0.00% <0.00%> (-100.00%) ⬇️
...Sentry/PlatformAbstractions/FrameworkInfo.NetFx.cs 0.00% <0.00%> (-70.43%) ⬇️
...rmAbstractions/NetFxInstallationsEventProcessor.cs 4.54% <0.00%> (-68.19%) ⬇️
...ntry/PlatformAbstractions/FrameworkInstallation.cs 25.00% <0.00%> (-37.50%) ⬇️
...ntry/Integrations/NetFxInstallationsIntegration.cs 28.57% <0.00%> (-28.58%) ⬇️
src/Sentry/PlatformAbstractions/RuntimeInfo.cs 53.44% <0.00%> (-5.18%) ⬇️
src/Sentry/Internal/BackgroundWorker.cs 92.02% <0.00%> (-1.45%) ⬇️
src/Sentry/Exceptions/SentryStackFrame.cs 80.48% <0.00%> (-1.22%) ⬇️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 945c3d9...ab5ad18. Read the comment docs.

@SimonCropp SimonCropp merged commit f8b157d into main Feb 7, 2022
@SimonCropp SimonCropp deleted the fix-IoException-from-network branch February 7, 2022 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unobservable Exceptions from the SDK are being captured and sent to Clients.
5 participants