-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup diagnostic source #1529
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nits in comments, but LGTM so far. 👍
src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentryDiagnosticSubscriber.cs
Outdated
Show resolved
Hide resolved
src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentryEFCoreListener.cs
Outdated
Show resolved
Hide resolved
src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentryEFCoreListener.cs
Show resolved
Hide resolved
src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentrySqlListener.cs
Outdated
Show resolved
Hide resolved
src/Sentry.DiagnosticSource/Internals/DiagnosticSource/SentrySqlListener.cs
Outdated
Show resolved
Hide resolved
test/Sentry.DiagnosticSource.Tests/SentryEFCoreListenerTests.cs
Outdated
Show resolved
Hide resolved
@mattjohnsonpint i have made a few more changes. can u give this another once over |
Codecov Report
@@ Coverage Diff @@
## main #1529 +/- ##
==========================================
+ Coverage 82.73% 82.75% +0.01%
==========================================
Files 219 219
Lines 7398 7418 +20
Branches 1421 1418 -3
==========================================
+ Hits 6121 6139 +18
- Misses 852 856 +4
+ Partials 425 423 -2
Continue to review full report at Codecov.
|
No description provided.