remove confusing message Successfully sent cached envelope #1542
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the CachingTransport we have:
But inside the HttpTransport we have:
So for error response codes (eg bad payloads like #1523 ) it is swallowed.
so the diagnostic log says
IMO since HttpTransport does a
Envelope '{0}' sent successfully
on success. the CachingTransportSuccessfully sent
is redundant on success, and misleading on failure.