Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial MAUI support #1663

Merged
merged 33 commits into from
May 24, 2022
Merged

Initial MAUI support #1663

merged 33 commits into from
May 24, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

Adding first set of projects for MAUI (see #1651).

  • Captures unhandled exceptions from managed code only.
  • Unit tests for UseSentry registration methods
  • Sample app that throws an unhandled exception and sends to Sentry:

image

image

@mattjohnsonpint mattjohnsonpint marked this pull request as draft May 19, 2022 21:21
@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review May 22, 2022 20:05
@mattjohnsonpint mattjohnsonpint marked this pull request as draft May 23, 2022 19:50
@mattjohnsonpint
Copy link
Contributor Author

MAUI just went GA. I'll update and take one more pass at this before we merge.

@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review May 23, 2022 22:14
@mattjohnsonpint mattjohnsonpint marked this pull request as draft May 24, 2022 00:33
@SimonCropp
Copy link
Contributor

so the sample seems overly large for just demonstrating MAUI. eg can we remove the fonts, the image, aboutassets.txt, and any other stuff to trim it down

@SimonCropp
Copy link
Contributor

can we remove the styles as well?

@mattjohnsonpint
Copy link
Contributor Author

For now, I just want to use the sample app that comes with the MAUI default app template. We can trim it down later.

@mattjohnsonpint
Copy link
Contributor Author

Something's broken with the sample app after updating to the MAUI GA. I'm investigating...

@mattjohnsonpint
Copy link
Contributor Author

The Android app crashes immediately on startup if Sentry.csproj is compiled with the net6.0-android target. This worked in MAUI RC3, but isn't in GA. I'll investigate more tomorrow. For now, I've temporarily disabled that target so the sample app should stop crashing.

@mattjohnsonpint
Copy link
Contributor Author

... That broke the Sentry.Samples.Android build, of course.

@SimonCropp
Copy link
Contributor

i assume we want to disable this ?

image

@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review May 24, 2022 16:53
@mattjohnsonpint mattjohnsonpint merged commit 7e4ca2c into main May 24, 2022
@mattjohnsonpint mattjohnsonpint deleted the maui branch May 24, 2022 17:31
@mattjohnsonpint
Copy link
Contributor Author

i assume we want to disable this ?
...

Sure. I'll define that constant in the next MAUI update PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants