Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ISentryTransactionProcessor #1862

Merged
merged 21 commits into from
Sep 2, 2022
Merged

Add ISentryTransactionProcessor #1862

merged 21 commits into from
Sep 2, 2022

Conversation

SimonCropp
Copy link
Contributor

fixes #1468

@getsentry getsentry deleted a comment from github-actions bot Aug 19, 2022
@SimonCropp
Copy link
Contributor Author

@mattjohnsonpint does options.TransactionProcessors need to be added to the bindings?

@mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint does options.TransactionProcessors need to be added to the bindings?

I think you're asking if we need to connect custom transaction processors to native iOS/Android events? At the moment, we don't support that for custom event processors, so I don't expect that for transaction processors either. When/if we do that, we'll do it for both at the same time.

@mattjohnsonpint mattjohnsonpint merged commit 5576f89 into main Sep 2, 2022
@mattjohnsonpint mattjohnsonpint deleted the transaction-processor branch September 2, 2022 00:48
This was referenced Oct 15, 2022
Merged
Merged
@mattjohnsonpint mattjohnsonpint mentioned this pull request Dec 6, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ISentryEventProcessor doesn't do anything for transactions
2 participants
@SimonCropp @mattjohnsonpint