Add ISpan.GetTransaction
convenience method
#2014
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a convenience method for when you have an
ISpan
and need to get theITransaction
it belongs to.For example:
This also works well anywhere we have a
GetSpan
method, such asIHub
andSentrySdk
or
Motivation
With custom measurements added in #2013, we have this:
Since sometimes we only have a span, we need to do this:
The alternative would have been to attach
SetMeasurement
extension methods onISpan
as well, but that would imply that measurement data is set on individual spans - which it is not.This seems cleaner and has other usages as well.