Add EnableTracing option
#2201
Merged
Add EnableTracing option
#2201
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
SeanFeldman
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new option
EnableTracingwhich simplifies enabling the Sentry SDK's tracing features.true, tracing will be enabled. No other settings are required, but will be honored if set.false, tracing will be disabled, regardless of other settings.null(the default), the current behavior will be used (which is to followTracesSampleRateorTracesSampler)No changes are required, but if you're starting a new app I recommend using
EnableTracing = trueinstead ofTracesSampleRate = 1.0.I've also updated all samples that can leverage tracing to have tracing enabled, using the new option.
Closes #2158