Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce debug files uploaded #2404

Merged
merged 8 commits into from
Jun 1, 2023
Merged

Reduce debug files uploaded #2404

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
db644f0
Specify symbol upload types
mattjohnsonpint Jun 1, 2023
d5c4886
Update CHANGELOG.md
mattjohnsonpint Jun 1, 2023
cd6a27c
Update tests
mattjohnsonpint Jun 1, 2023
f5ad273
Merge branch 'main' into fix/reduce-symbol-uploads
mattjohnsonpint Jun 1, 2023
1e049ab
Update CHANGELOG.md
mattjohnsonpint Jun 1, 2023
963c649
Update sentry-cli-integration.Tests.ps1
mattjohnsonpint Jun 1, 2023
cfca90b
Update sentry-cli-integration.Tests.ps1
mattjohnsonpint Jun 1, 2023
b7d8462
Merge branch 'main' into fix/reduce-symbol-uploads
mattjohnsonpint Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- The device architecture (x64, arm64, etc.) is now reported
- On Windows, the OS type is now reported as "Windows" instead of "WinUI". Additionally, the OS display version (ex, "22H2") is now included.
- `UIKit`, `ABI.Microsoft` and `WinRT` frames are now marked "system" instead of "in app".
- Reduce debug files uploaded ([#2404](https://github.com/getsentry/sentry-dotnet/pull/2404))
- Fix system frames being marked as "in-app" ([#2408](https://github.com/getsentry/sentry-dotnet/pull/2408))
- NOTE: This important fix corrects a value that is used during issue grouping, so you may receive new alerts for existing issues after deploying this update.

Expand Down
9 changes: 8 additions & 1 deletion src/Sentry/buildTransitive/Sentry.targets
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,14 @@
<Message Importance="High"
Text="Preparing to upload debug symbols to Sentry for $(MSBuildProjectName) ($(Configuration)/$(TargetFramework))" />

<Exec Command="$(SentryCLIUploadCommand) $(OutputPath)" IgnoreExitCode="true" ContinueOnError="WarnAndContinue">
<ItemGroup>
<SentryCLIUploadSymbolType Include="pdb" />
<SentryCLIUploadSymbolType Include="portablepdb" />
<SentryCLIUploadSymbolType Include="dsym" Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'ios'" />
<SentryCLIUploadSymbolType Include="dsym" Condition="$([MSBuild]::GetTargetPlatformIdentifier('$(TargetFramework)')) == 'maccatalyst'" />
</ItemGroup>

<Exec Command="$(SentryCLIUploadCommand) @(SentryCLIUploadSymbolType -> '-t %(Identity)', ' ') $(OutputPath)" IgnoreExitCode="true" ContinueOnError="WarnAndContinue">
<Output TaskParameter="ExitCode" PropertyName="_SentryCLIExitCode" />
</Exec>

Expand Down
4 changes: 0 additions & 4 deletions test/sentry-cli-integration.Tests.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,25 +53,21 @@ BeforeAll {
Describe 'CLI-integration' {

It "uploads symbols and sources for a console app build" {
$exe = [RuntimeInformation]::IsOSPlatform([OSPlatform]::Windows) ? '.exe' : ''
$result = DotnetBuild 'Sentry.Samples.Console.Basic' $True $True
$result.ScriptOutput | Should -Contain 'Build succeeded.'
$result.HasErrors() | Should -BeFalse
$result.UploadedDebugFiles() | Sort-Object -Unique | Should -Be @(
'Sentry.pdb',
"Sentry.Samples.Console.Basic$exe",
'Sentry.Samples.Console.Basic.pdb',
'Sentry.Samples.Console.Basic.src.zip')
}

It "uploads symbols for a console app build" {
$exe = [RuntimeInformation]::IsOSPlatform([OSPlatform]::Windows) ? '.exe' : ''
$result = DotnetBuild 'Sentry.Samples.Console.Basic' $True $False
$result.ScriptOutput | Should -Contain 'Build succeeded.'
$result.HasErrors() | Should -BeFalse
$result.UploadedDebugFiles() | Sort-Object -Unique | Should -Be @(
'Sentry.pdb',
"Sentry.Samples.Console.Basic$exe",
'Sentry.Samples.Console.Basic.pdb')
}

Expand Down