-
-
Notifications
You must be signed in to change notification settings - Fork 205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MinimumEventLevel to Sentry.Log4Net and convert events below it to breadcrumbs #2505
Add MinimumEventLevel to Sentry.Log4Net and convert events below it to breadcrumbs #2505
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@IhateTrains thank you so much for the contribution.
I added a few comments but generally looking pretty good 👍🏻
This is looking great @IhateTrains ! Just the small tweak to be made to LevelMappings and then getting the build checks passing. Let me know if you need any guidance/help working out the problems with the builds. ℹ️ One tip in that respect is search for the text |
@jamescrosswell turns out the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @IhateTrains ! Thanks heaps for the contribution 👍🏻
Co-authored-by: Sean Feldman <SeanFeldman@users.noreply.github.com>
Both NLog and Serilog integrations already feature
MinimumEventLevel
. I attempted to also add it for log4net, hope its implementation is acceptable to you.If
MinimumEventLevel
is specified, every log4net LoggingEvent abovethreshold
and belowMinimumEventLevel
will be converted to a breadcrumb.Heavily inspired by this solution from SO:
https://stackoverflow.com/a/62923187/10249243