Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IHasTags and IHasExtra replaced with ITagsAndData #2675

Closed
wants to merge 2 commits into from

Conversation

jamescrosswell
Copy link
Collaborator

IHasTags and IHasExtra can be merged as anything that implements one also implements the other.
SDK users should use ITagsAndData instead.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 27, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 9454b9b

@bitsandfoxes
Copy link
Contributor

bitsandfoxes commented Sep 27, 2023

That one seems a bit odd with those two small and distinct things now bundled up in one interface.
The interfaces get used in IEventLike and ISpanData but actually accessed very differently. I.e.ISpanData does not get passed through the Enricher to have the defaults set but has them there to be accessed by users.
Instead of merging them, can we get rid of them?

@jamescrosswell
Copy link
Collaborator Author

@bitsandfoxes yes, putting an And in the name of any class/interface is a bit of a smell... it usually indicates you have two unrealted things. I think in this case, we probably need to think about why these things might be sitting together on the same interface and what the name for that "single" purpose is. I opened a related issue: #2676 but maybe we think about renaming these immediately (before merging this pull request). Essentially I'm suggesting a better name for ITagsAndData might be IScopeData... but that depends whether I'm on the same wavelength as everyone else wrt IEventLike and how the shift from Transactions to Spans will play out.

Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't seem worth the change but seems like you and Stefan also got to that conclusion

@jamescrosswell jamescrosswell deleted the feat/4.0.0-merge-tags-and-extra branch November 22, 2023 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants