feat: Add NET8 to major packages #2852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bruno-garcia
requested changes
Nov 16, 2023
bitsandfoxes
approved these changes
Nov 16, 2023
samples/Sentry.Samples.Console.Basic/Sentry.Samples.Console.Basic.csproj
Show resolved
Hide resolved
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>net6.0;netstandard2.0;net462</TargetFrameworks> | |||
| <TargetFrameworks>net8.0;net6.0;netstandard2.1;netstandard2.0;net462</TargetFrameworks> | |||
There was a problem hiding this comment.
I was hoping we would get rid of ns2.1 if we can, but avoid adding it to more libraries.
It's fair that the lib supports it and so does the Sentry core SDK. But the package is fairly lower in terms of usage: https://nugettrends.com/packages?months=72&ids=Sentry.NLog&ids=Sentry
And most people are updating their runtimes. .NET Standard 2.1 came to help bridge .NET Framework and .NET Core 3.1. We had .NET 5,6,7,8 now so hoping we can get rid of those netstandard
How about we remove this?
There was a problem hiding this comment.
NLog doesn't have ns2.1: https://www.nuget.org/packages/NLog#dependencies-body-tab
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#skip-changelog