Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix changelog heading #2899

Merged
merged 1 commit into from
Nov 23, 2023
Merged

fix changelog heading #2899

merged 1 commit into from
Nov 23, 2023

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Nov 23, 2023 •
edited
Loading

#skip-changelog

@bruno-garcia bruno-garcia enabled auto-merge (squash) November 23, 2023 22:02
@bruno-garcia
Copy link
Member Author

I wish CI woudn't run for a changelog reword 😓

@bruno-garcia bruno-garcia merged commit 73cd14c into main Nov 23, 2023
12 checks passed
@bruno-garcia bruno-garcia deleted the fix/changelog-heading branch November 23, 2023 22:03
@AbhiPrasad
Copy link
Member

I wish CI woudn't run for a changelog reword 😓

Sounds like you need to set up https://github.com/getsentry/paths-filter!

@bruno-garcia
Copy link
Member Author

yeah you can also define the paths to ignore, including the file names (built-in to GHA) but it's kind of annoying:

https://github.com/dotnet/nuget-trends/blob/cdf5cf1166c479a8bbe5b4d4f5b65c7b5cc8b74a/.github/workflows/scheduler-workflow.yml#L11-L23

But prob best to get this done anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AbhiPrasad AbhiPrasad AbhiPrasad approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes bitsandfoxes is a code owner

@jamescrosswell jamescrosswell Awaiting requested review from jamescrosswell jamescrosswell is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruno-garcia @AbhiPrasad