refactor: rename native options #2940
Conversation
|
|
||
| #### Changed APIs | ||
|
|
||
| - Rename iOS and MacCatalyst platform specific options from `Cocoa` to `Native` ([#2940](https://github.com/getsentry/sentry-dotnet/pull/2940)) |
There was a problem hiding this comment.
Note to final 4.0.0 changelog rewording: outside the beta there was no Cocoa, it was iOS to Native (right?)
There was a problem hiding this comment.
Yes and that is also true for many other parts of the 4.0 changelog. we need to update it and review thoroughly before the final release.
There was a problem hiding this comment.
We could keep track of these things in a ticket (we already have #2673)?
| @@ -9,17 +9,17 @@ internal class AndroidEventProcessor : ISentryEventProcessor, IDisposable | |||
| private readonly JavaSdk.IEventProcessor? _androidProcessor; | |||
| private readonly JavaSdk.Hint _hint = new(); | |||
|
|
|||
| public AndroidEventProcessor(SentryAndroidOptions androidOptions) | |||
| public AndroidEventProcessor(SentryAndroidOptions nativeOptions) | |||
There was a problem hiding this comment.
Should class SentryAndroidOptions also become SentryNativeOptions or that's rather confusing because sentry-native?
Although I see it being renamed below, did we have 2 SentryAndroidOptionss?
There was a problem hiding this comment.
This refers to Java class name
| @@ -6,7 +6,7 @@ | |||
|
|
|||
| <ItemGroup> | |||
| <Using Include="Foundation" /> | |||
| <Using Include="Sentry.CocoaSdk.SentryOptions" Alias="SentryCocoaOptions" /> | |||
| <Using Include="Sentry.CocoaSdk.SentryOptions" Alias="SentryCocoaSdkOptions" /> | |||
There was a problem hiding this comment.
How about?
| <Using Include="Sentry.CocoaSdk.SentryOptions" Alias="SentryCocoaSdkOptions" /> | |
| <Using Include="Sentry.CocoaSdk.SentryOptions" Alias="SentryCocoaOptions" /> |
Not sure the namespace is CocoaSdk, could it be Cocoa? Do we call JavaSdk or AndroidSdk on the other binding?
There was a problem hiding this comment.
This is related to the native cocoa SDK generated binding code. I didn't want to touch that internal bit
closes #2934