OpenTelemetry integration throws an exception when Sentry is disabled

[jamescrosswell]

Fixes #3155

Ultimately I've fixed this in the TraceProviderBuilderExtensions:

sentry-dotnet/src/Sentry.OpenTelemetry/TracerProviderBuilderExtensions.cs

Lines 45 to 47 in 3b09187

	return hub.IsEnabled
	? new SentrySpanProcessor(hub, enrichers)
	: DisabledSpanProcessor.Instance;

I also refactored those slighly for testability.

Note

We didn't pick up on this because we configure the DSN via an attribute in our sample projects... so even if you tried to force the DSN to be disabled when using our Otel sample, it would use a Valid DSN 😢

sentry-dotnet/samples/Directory.Build.props

Lines 25 to 29 in 6f037bd

	<ItemGroup>
	<SentryAttributes Include="Sentry.DsnAttribute">
	<_Parameter1>https://eb18e953812b41c3aeb042e666fd3b5c@o447951.ingest.sentry.io/5428537</_Parameter1>
	</SentryAttributes>
	</ItemGroup>

[bitsandfoxes]

We didn't pick up on this because we configure the DSN via an attribute in our sample projects...

Maybe it's time to remove the attribute again? I wasn't even aware we were doing this until last week and ran headfirst into a wall with the assumption that we don't.

[bitsandfoxes]

Thanks for the fix!

premature

[jamescrosswell]

Maybe it's time to remove the attribute again? I wasn't even aware we were doing this until last week and ran headfirst into a wall with the assumption that we don't.

Yeah I think we can always set an environment variable if we want/need... I'm OK with removing it. Separate PR for that maybe?