Panic in fasthttp handler

[ainar-g]

Summary

The fasthttp integration can panic when converting a fasthttp context into an *http.Request.

Steps To Reproduce

If the URL parsing fails at

sentry-go/fasthttp/sentryfasthttp.go

Line 151 in 24ffea5

r.URL, _ = url.Parse(fmt.Sprintf("%s://%s%s", uri.Scheme(), uri.Host(), uri.Path()))

this panics,

sentry-go/fasthttp/sentryfasthttp.go

Line 170 in 24ffea5

r.URL.RawQuery = string(ctx.URI().QueryString())

and while that panic is caught,

sentry-go/fasthttp/sentryfasthttp.go

Lines 140 to 144 in 24ffea5

	defer func() {
	if err := recover(); err != nil {
	sentry.Logger.Printf("%v", err)
	}
	}()

that means that this line panics now, since r is now nil.

sentry-go/fasthttp/sentryfasthttp.go

Line 73 in 24ffea5

sentry.ContinueTrace(hub, r.Header.Get(sentry.SentryTraceHeader), r.Header.Get(sentry.SentryBaggageHeader)),

Expected Behavior

No panics.

Screenshots

[not applicable]

Sentry.io Event

[not applicable]

Environment

SDK

• sentry-go version: v0.29.1
• Go version: Go 1.23.3
• Using Go Modules? yes

Sentry

[not applicable]

Additional context

The solution is to either always return a non-nil request from convert or not expect that r is always non-nil in Handle.

[cleptric]

A fix was released in version 0.30.0.