Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent panic in case url.Parsing fails in fasthttp and fiber #912

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

ribice
Copy link
Collaborator

@ribice ribice commented Nov 30, 2024

Resolves #911

If r.URL is not set due to some error, setting r.URL.RawQuery panics. Panic is recovered, but request is never converted thus causing another panic.

@ribice ribice requested a review from cleptric November 30, 2024 10:47
Copy link

codecov bot commented Nov 30, 2024

Codecov Report

Attention: Patch coverage is 88.46154% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.16%. Comparing base (9ed1fa9) to head (b084369).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
fiber/sentryfiber.go 80.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #912      +/-   ##
==========================================
- Coverage   83.21%   83.16%   -0.05%     
==========================================
  Files          55       55              
  Lines        5897     5899       +2     
==========================================
- Hits         4907     4906       -1     
- Misses        820      822       +2     
- Partials      170      171       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cleptric cleptric merged commit fd9725b into master Dec 2, 2024
16 checks passed
@cleptric cleptric deleted the fasthttp-panic-prevent branch December 2, 2024 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panic in fasthttp handler
2 participants