fix(stacktrace): Correctly report package names and ignore subpackages #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
previously approved these changes
Dec 18, 2019
rhcarvalho
commented
Dec 18, 2019
| // packageName returns the package part of the symbol name, or the empty string | ||
| // if there is none. | ||
| // It replicates https://golang.org/pkg/debug/gosym/#Sym.PackageName, avoiding a | ||
| // dependency on debug/gosym. |
There was a problem hiding this comment.
This is intentional, because:
- https://go-proverbs.github.io, "A little copying is better than a little dependency."
- Avoids increasing the size of binaries that include the SDK (see Big distribution size of sentry-go (~ 8MB) #75)
Makes function receivers part of the function name and not part of the package name.
Compared to release v0.3.1, now filteredFrames compares the frame.Module value instead of frame.AbsPath, and ignores SDK "_test" packages instead of pattern matching test files and examples. However confusing it might be, frame.Module holds a package name, unrelated to Go Modules. This fixes up the regression introduced in 61d7ccc, which caused frames from integrations/subpackages to be reported to Sentry.
rhcarvalho
force-pushed
the
deconstruct-function-name
branch
from
068b461 to
bf38760
Compare
rhcarvalho
changed the title
rhcarvalho
changed the title
untitaker
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes function receivers part of the function name and not part of the package name.
Add tests and fix
filteredFramesto ensure it ignores all packages related to the SDK.Fixes #126.