Add tests for net/http and fasthttp integrations #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without `./...` only the top-level package was built and tested.
bruno-garcia
previously approved these changes
Feb 24, 2020
rhcarvalho
force-pushed
the
integration-tests
branch
from
2a97dff to
9ecab01
Compare
rhcarvalho
force-pushed
the
integration-tests
branch
from
9ecab01 to
078f12a
Compare
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should allow us to make changes to
sentry-gowith some confidence that integrations still work.Targeting
net/httpandfasthttpbecause other integrations (echo,gin,iris,martini,negroni) are similar tonet/http, so we cover most of the surface area.The tests cover 3 scenarios:
The tests in
sentryhttpandsentryfasthttpare pretty similar, however need to account for differences innet/httpandfasthttp.Updates #97.