Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Rename example/ directory to _examples/ #521

Merged
merged 4 commits into from
Jan 9, 2023
Merged

Conversation

tonyo
Copy link
Contributor

@tonyo tonyo commented Dec 28, 2022

This is point 1 of #79 (not turning the example folders into modules here).

go help packages tells us:

Directory and file names that begin with "." or "_" are ignored
by the go tool, as are directories named "testdata".

The main motivation is to avoid any issues with unnecessary 3rd party dependencies in the examples, so that e.g. go mod tidy doesn't add new funny things to the go.mod in root.

Regarding point 2 in #79 (adding go.mod/go.sum to every example folder) -- not doing it right now: after some internal discussion, the future of having examples folder in this repos is somewhat unclear.

Things to check before merging:

@tonyo tonyo merged commit e081f7e into master Jan 9, 2023
@tonyo tonyo deleted the feat/examples-rename branch January 9, 2023 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants