Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Span.IsTransaction() #543

Merged
merged 6 commits into from
Jan 23, 2023
Merged

feat: Add Span.IsTransaction() #543

merged 6 commits into from
Jan 23, 2023

Conversation

cleptric
Copy link
Member

This is needed for OTel (#537).

@cleptric cleptric self-assigned this Jan 22, 2023
@cleptric cleptric requested a review from tonyo January 22, 2023 21:00
@codecov
Copy link

codecov bot commented Jan 22, 2023

Codecov Report

Base: 84.31% // Head: 84.25% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (2c40ce4) compared to base (946b556).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #543      +/-   ##
==========================================
- Coverage   84.31%   84.25%   -0.06%     
==========================================
  Files          23       23              
  Lines        2825     2827       +2     
==========================================
  Hits         2382     2382              
- Misses        362      364       +2     
  Partials       81       81              
Impacted Files Coverage Δ
tracing.go 84.89% <100.00%> (+0.07%) ⬆️
transport.go 77.80% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@tonyo tonyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple suggestions

tracing.go Outdated Show resolved Hide resolved
tracing_test.go Outdated Show resolved Hide resolved
cleptric and others added 4 commits January 23, 2023 12:22
Co-authored-by: Anton Ovchinnikov <anton@tonyo.info>
Co-authored-by: Anton Ovchinnikov <anton@tonyo.info>
@cleptric cleptric merged commit b4119e9 into master Jan 23, 2023
@cleptric cleptric deleted the cleptric/is-transaction branch January 23, 2023 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants