-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gin): Add transactions to Gin integration #644
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #644 +/- ##
==========================================
+ Coverage 79.64% 80.02% +0.37%
==========================================
Files 38 38
Lines 3896 3944 +48
==========================================
+ Hits 3103 3156 +53
+ Misses 683 675 -8
- Partials 110 113 +3
☔ View full report in Codecov by Sentry. |
Hey @zetaab , thanks for the changes 👍 Could be something like https://github.com/getsentry/sentry-go/blob/master/http/sentryhttp_test.go, but can be even simpler (at least to make sure it doesn't crash). |
@tonyo yeah I will do those, just take some days :) |
@tonyo sorry for copy pasting the tests, but now its almost similar than in normal http lib. This does not include transaction tests. I will continue with those tomorrow. |
actually it was quite easy to add transaction tests, so those are included now as well |
Thanks, we'll take a closer look soon. For now, please revert any dependency bumps as we do not want to raise our base level. |
options..., | ||
) | ||
defer func() { | ||
transaction.Status = sentry.HTTPtoSpanStatus(c.Writer.Status()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added Status and tests for that as well
Thanks! |
add missing transactions for gin