Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: real ticker profiling in CI with a long duration #653

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented Jun 13, 2023

Enables the TestProfilerCollection/RealTicker test in CI but with a long duration, in hopes it won't be flaky in CI.

Requested in https://github.com/getsentry/sentry-go/pull/626/files/c3ce952783a3b8d68042fd8367add1dad837e5b9#r1213167528

#skip-changelog

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.07 ⚠️

Comparison is base (97a00a4) 80.65% compared to head (8fd9389) 80.58%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #653      +/-   ##
==========================================
- Coverage   80.65%   80.58%   -0.07%     
==========================================
  Files          43       43              
  Lines        4332     4332              
==========================================
- Hits         3494     3491       -3     
- Misses        712      714       +2     
- Partials      126      127       +1     

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@vaind vaind marked this pull request as ready for review June 13, 2023 17:34
@vaind vaind changed the title test: test real ticker profiling in CI with a long duration test: real ticker profiling in CI with a long duration Jun 13, 2023
@vaind vaind merged commit 0581ede into master Jun 14, 2023
@vaind vaind deleted the test/profiler-real-ticker-in-ci branch June 14, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants