-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing stack trace for parsing error in logrusentry #689
Conversation
4c84592
to
5caf94e
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #689 +/- ##
==========================================
- Coverage 82.06% 82.01% -0.05%
==========================================
Files 49 49
Lines 4872 4844 -28
==========================================
- Hits 3998 3973 -25
+ Misses 732 730 -2
+ Partials 142 141 -1 ☔ View full report in Codecov by Sentry. |
I added the changes from RFC 0079 (parent_id, exception_id and is_exception_group). Apart from that this PR fixed the issue with missing stacktrace. Once #792 is merged as well, I'll create a common function for extracting errors and creating exceptions so that it's not rewritten wherever needed. |
fix #677