Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing stack trace for parsing error in logrusentry #689

Merged
merged 8 commits into from
Apr 2, 2024

Conversation

yiuiua
Copy link
Contributor

@yiuiua yiuiua commented Aug 7, 2023

fix #677

@yiuiua yiuiua changed the title fix: missing stack track for parsing error in logrusentry #677 fix: missing stack track for parsing error in logrusentry Aug 7, 2023
@yiuiua yiuiua changed the title fix: missing stack track for parsing error in logrusentry fix: missing stack trace for parsing error in logrusentry Aug 7, 2023
@codecov
Copy link

codecov bot commented Aug 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (7b5b621) to head (c03711a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #689      +/-   ##
==========================================
- Coverage   82.06%   82.01%   -0.05%     
==========================================
  Files          49       49              
  Lines        4872     4844      -28     
==========================================
- Hits         3998     3973      -25     
+ Misses        732      730       -2     
+ Partials      142      141       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ribice
Copy link
Collaborator

ribice commented Mar 17, 2024

image

I added the changes from RFC 0079 (parent_id, exception_id and is_exception_group). Apart from that this PR fixed the issue with missing stacktrace.

Once #792 is merged as well, I'll create a common function for extracting errors and creating exceptions so that it's not rewritten wherever needed.

@ribice ribice requested a review from phacops March 17, 2024 17:48
@ribice ribice requested a review from vaind March 26, 2024 15:49
vaind
vaind previously requested changes Mar 26, 2024
logrus/logrusentry.go Outdated Show resolved Hide resolved
@ribice ribice requested a review from vaind March 26, 2024 17:55
@ribice ribice requested a review from cleptric April 2, 2024 09:23
@cleptric cleptric dismissed vaind’s stale review April 2, 2024 16:06

Concerns were addressed

@ribice ribice merged commit 89924ea into getsentry:master Apr 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing stack trace when using the logrus integration
5 participants