Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Guard against a nil client when setting the SDK identifer #715

Merged
merged 2 commits into from
Sep 13, 2023
Merged

fix: Guard against a nil client when setting the SDK identifer #715

merged 2 commits into from
Sep 13, 2023

Conversation

cleptric
Copy link
Member

Fixes #714

@cleptric cleptric self-assigned this Sep 13, 2023
@cleptric cleptric requested a review from tonyo September 13, 2023 12:18
@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage is 42.85% of modified lines.

Files Changed Coverage
echo/sentryecho.go 0.00%
iris/sentryiris.go 0.00%
martini/sentrymartini.go 0.00%
negroni/sentrynegroni.go 0.00%
fasthttp/sentryfasthttp.go 100.00%
gin/sentrygin.go 100.00%
http/sentryhttp.go 100.00%

📢 Thoughts on this report? Let us know!.

@cleptric cleptric merged commit 1d05fa5 into master Sep 13, 2023
16 of 17 checks passed
@cleptric cleptric deleted the sdk-identifier-panic branch September 13, 2023 12:42
@DavidS-ovm
Copy link

Wow, thanks! That was quick 😅

I owe you a coffee or summat. Maybe at the next rust meetup?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tonyo tonyo tonyo approved these changes

Assignees

@cleptric cleptric

Labels
Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sentrygin panic on SetSDKIdentifier when no client available
3 participants
@cleptric @DavidS-ovm @tonyo