-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: global tags #718
feat: global tags #718
Conversation
Add global tags support. Tags can be passed via client options or via environment variables by prefixing them with "SENTRY_TAGS_". Setting scope tags overrides global tags. Client option tags override environment variable tags.
Hmm seems tests are failing from an empty map being present instead of nil. I'll fix. |
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
@tonyo comments addressed. :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed another small thing, otherwise LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one!
Add global tags support.
Tags can be passed via client options or via environment variables by prefixing them with "SENTRY_TAGS_".
Setting scope tags overrides global tags.
Client option tags override environment variable tags.
Fixes: #331