-
Notifications
You must be signed in to change notification settings - Fork 215
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tracing without performance improvements #862
Conversation
4194276
to
0d01892
Compare
e7f5b13
to
35092b3
Compare
// create one from the properties of the transaction. | ||
if !s.dynamicSamplingContext.IsFrozen() { | ||
// This will return a frozen DynamicSamplingContext. | ||
if dsc := DynamicSamplingContextFromTransaction(t); dsc.HasEntries() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cleptric Not sure if this will cause unwanted changes, but it did fix the failing test because it was setting the dynamicSamplingContext to "" due to nil client.
I fixed the gin panic issue. But with these changes, in |
Resolved. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #862 +/- ##
==========================================
- Coverage 82.90% 82.79% -0.11%
==========================================
Files 55 55
Lines 4603 4610 +7
==========================================
+ Hits 3816 3817 +1
- Misses 633 636 +3
- Partials 154 157 +3 ☔ View full report in Codecov by Sentry. |
No description provided.