Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
  • Loading branch information
adinauer and romtsn authored Jun 30, 2023
1 parent 23dcd1a commit a360064
Showing 1 changed file with 3 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -382,15 +382,13 @@ public synchronized void onActivityStarted(final @NotNull Activity activity) {
// working. Moving this to onActivityStarted fixes the problem.
activityFramesTracker.addActivity(activity);
}
if (options.isEnableActivityLifecycleBreadcrumbs()) {
addBreadcrumb(activity, "started");
}
addBreadcrumb(activity, "started");
}

@SuppressLint("NewApi")
@Override
public synchronized void onActivityResumed(final @NotNull Activity activity) {
if (performanceEnabled || options.isEnableActivityLifecycleBreadcrumbs()) {
if (performanceEnabled) {
// app start span
@Nullable final SentryDate appStartStartTime = AppStartState.getInstance().getAppStartTime();
@Nullable final SentryDate appStartEndTime = AppStartState.getInstance().getAppStartEndTime();
Expand All @@ -414,8 +412,8 @@ public synchronized void onActivityResumed(final @NotNull Activity activity) {
// its current job. That is, right after the activity draws the layout.
mainHandler.post(() -> onFirstFrameDrawn(ttfdSpan, ttidSpan));
}
addBreadcrumb(activity, "resumed");
}
addBreadcrumb(activity, "resumed");
}

@Override
Expand Down

0 comments on commit a360064

Please sign in to comment.