code review changes

getsentry · Sep 3, 2024 · d63db29 · d63db29
1 parent f9b17d8
commit d63db29
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 4 deletions.
diff --git a/sentry/src/main/java/io/sentry/SentryOptions.java b/sentry/src/main/java/io/sentry/SentryOptions.java
@@ -490,6 +490,7 @@ public class SentryOptions {
   private @NotNull ScopeType defaultScopeType = ScopeType.ISOLATION;
 
   private @NotNull InitPriority initPriority = InitPriority.MEDIUM;
+
   private boolean forceInit = false;
 
   /**
@@ -2592,7 +2593,6 @@ public SentryOptions() {
    */
   private SentryOptions(final boolean empty) {
     if (!empty) {
-      setInitPriority(InitPriority.LOWEST);
       setSpanFactory(new DefaultSpanFactory());
       // SentryExecutorService should be initialized before any
       // SendCachedEventFireAndForgetIntegration

diff --git a/sentry/src/test/java/io/sentry/SentryOptionsTest.kt b/sentry/src/test/java/io/sentry/SentryOptionsTest.kt
@@ -728,4 +728,9 @@ class SentryOptionsTest {
         assertEquals(30, options.cron?.defaultFailureIssueThreshold)
         assertEquals(40, options.cron?.defaultRecoveryThreshold)
     }
+
+    @Test
+    fun `when options is initialized, InitPriority is set to MEDIUM by default`() {
+        assertEquals(SentryOptions().initPriority, InitPriority.MEDIUM)
+    }
 }
diff --git a/sentry/src/test/java/io/sentry/util/InitUtilTest.kt b/sentry/src/test/java/io/sentry/util/InitUtilTest.kt
@@ -2,15 +2,23 @@ package io.sentry.util
 
 import io.sentry.InitPriority
 import io.sentry.SentryOptions
+import kotlin.test.BeforeTest
 import kotlin.test.Test
 import kotlin.test.assertFalse
 import kotlin.test.assertTrue
 
 class InitUtilTest {
 
-    var previousOptions: SentryOptions? = null
-    var newOptions: SentryOptions? = null
-    var clientEnabled: Boolean = true
+    private var previousOptions: SentryOptions? = null
+    private var newOptions: SentryOptions? = null
+    private var clientEnabled: Boolean = true
+
+    @BeforeTest
+    fun setup() {
+        previousOptions = null
+        newOptions = null
+        clientEnabled = true
+    }
 
     @Test
     fun `first init on empty options goes through`() {