Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make File I/O instrumentation configurable to not log filename/path #3324

Closed
devPalacio opened this issue Apr 3, 2024 · 4 comments
Closed
Milestone

Comments

@devPalacio
Copy link

Problem Statement

I want to be able to use the file.read span without exposing user’s file paths. Currently, the filename is captured under Description and there’s also a file.path field in the data of the span.

In a perfect world I'd like to keep the file extension and file size. We're currently using data scrubbing rules to redact this information.

Solution Brainstorm

Expose a setting in SentryPluginExtension such as

sentry {
logFileNames = false
}
@romtsn
Copy link
Member

romtsn commented Apr 3, 2024

hi @devPalacio that makes sense! it'd have to be part of SentryOptions though and done at runtime rather than build time, but I guess it's also fine for you? Reason is, file i/o instrumentation can also be used manually, bypassing the gradle plugin magic, so we better expose this option at runtime

@devPalacio
Copy link
Author

Ya'll would have the best context on how to best implement it. Runtime works for me!

@romtsn romtsn transferred this issue from getsentry/sentry-android-gradle-plugin Apr 4, 2024
@getsantry getsantry bot removed the status in GitHub Issues with 👀 2 Apr 8, 2024
@stefanosiano
Copy link
Member

@devPalacio we have the option sendDefaultPii. We just don't apply this flag for the file path on Android.
Would it work to have this behaviour under the same sendDefaultPii option?
For the meantime we can add another option. When releasing the next major, we will evaluate to keep it or put everything under sendDefaultPii

@stefanosiano stefanosiano moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Apr 10, 2024
@stefanosiano stefanosiano added this to the 8.0.0 milestone Apr 10, 2024
@devPalacio
Copy link
Author

Putting this behavior under the existing pii option would be great, I'm not too picky on how ya'll decide to implement it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

4 participants