Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send file name and path only if isSendDefaultPii is true #3919

Merged
merged 3 commits into from
Nov 21, 2024

Conversation

stefanosiano
Copy link
Member

📜 Description

file span description is now masked if isSendDefaultPii is false
file path on Android is sent only if isSendDefaultPii is true

💡 Motivation and Context

Closes #3324

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

file path on Android is sent only if isSendDefaultPii is true
@stefanosiano stefanosiano changed the title file span description is now masked if isSendDefaultPii is false Send file name and path only if isSendDefaultPii is true Nov 21, 2024
@stefanosiano stefanosiano marked this pull request as ready for review November 21, 2024 10:27
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 418.94 ms 472.77 ms 53.83 ms
Size 1.65 MiB 2.31 MiB 675.34 KiB

Previous results on branch: fix/pii-sending-file-names

Startup times

Revision Plain With Sentry Diff
af3b385 442.73 ms 491.12 ms 48.39 ms

App size

Revision Plain With Sentry Diff
af3b385 1.65 MiB 2.31 MiB 673.46 KiB

Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, we should probably use our util for getting the file extension.

@stefanosiano stefanosiano merged commit e1b0b23 into 8.x.x Nov 21, 2024
29 of 30 checks passed
@stefanosiano stefanosiano deleted the fix/pii-sending-file-names branch November 21, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants