Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crashed last run #1739

Merged
merged 11 commits into from
Oct 4, 2021
Merged

Crashed last run #1739

merged 11 commits into from
Oct 4, 2021

Conversation

marandaneto
Copy link
Contributor

@marandaneto marandaneto commented Sep 24, 2021

📜 Description

Crashed last run

💡 Motivation and Context

Closes #1125

💚 How did you test it?

running and unit tests, also by the Unity integration

📝 Checklist

  • I reviewed the submitted code
  • I added tests to verify the changes
  • I updated the docs if needed
  • No breaking changes

🔮 Next steps

@codecov-commenter
Copy link

codecov-commenter commented Oct 4, 2021

Codecov Report

Merging #1739 (460b6d5) into main (7b4b8c2) will increase coverage by 0.14%.
The diff coverage is 84.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1739      +/-   ##
============================================
+ Coverage     75.20%   75.34%   +0.14%     
- Complexity     2137     2158      +21     
============================================
  Files           214      215       +1     
  Lines          7631     7699      +68     
  Branches        809      820      +11     
============================================
+ Hits           5739     5801      +62     
- Misses         1497     1502       +5     
- Partials        395      396       +1     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/HubAdapter.java 5.00% <0.00%> (-0.09%) ⬇️
sentry/src/main/java/io/sentry/IHub.java 86.36% <ø> (ø)
sentry/src/main/java/io/sentry/NoOpHub.java 46.34% <0.00%> (-1.16%) ⬇️
...y/src/main/java/io/sentry/cache/EnvelopeCache.java 53.29% <75.00%> (+4.47%) ⬆️
...c/main/java/io/sentry/SentryCrashLastRunState.java 94.44% <94.44%> (ø)
sentry/src/main/java/io/sentry/Hub.java 74.72% <100.00%> (+0.13%) ⬆️
sentry/src/main/java/io/sentry/Sentry.java 41.89% <100.00%> (+0.39%) ⬆️
sentry/src/main/java/io/sentry/SentryOptions.java 86.10% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b4b8c2...460b6d5. Read the comment docs.

@marandaneto marandaneto marked this pull request as ready for review October 4, 2021 08:47
@marandaneto marandaneto requested a review from a team October 4, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add crashedLastRun
3 participants