Send cpu usage percentage in profile payload #2469
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ndroid set in SentryOptions Added TransactionPerformanceCollector to collect performance data while a transaction is running
# Conflicts: # CHANGELOG.md # sentry/src/main/java/io/sentry/SentryTracer.java # sentry/src/main/java/io/sentry/TransactionPerformanceCollector.java # sentry/src/test/java/io/sentry/TransactionPerformanceCollectorTest.kt
…running TransactionPerformanceCollector now returns PerformanceCollectionData, which contains memory and cpu usage data
…s, instead of being created in every Hub
…files-memory-measurement
…emory-measurement # Conflicts: # CHANGELOG.md
AndroidTransactionProfiler now gets an instance of PerformanceCollectionData instead of MemoryCollectionData
# Conflicts: # CHANGELOG.md # sentry/src/main/java/io/sentry/TransactionPerformanceCollector.java
# Conflicts: # CHANGELOG.md # sentry/src/main/java/io/sentry/TransactionPerformanceCollector.java
…emory-measurement # Conflicts: # CHANGELOG.md # sentry/src/main/java/io/sentry/TransactionPerformanceCollector.java
|
stefanosiano
changed the title
Performance metrics 🚀
|
Codecov ReportBase: 80.13% // Head: 80.13% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #2469 +/- ##
=========================================
Coverage 80.13% 80.13%
Complexity 3917 3917
=========================================
Files 321 321
Lines 14788 14788
Branches 1951 1951
=========================================
Hits 11850 11850
Misses 2170 2170
Partials 768 768
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
# Conflicts: # CHANGELOG.md # sentry/src/main/java/io/sentry/TransactionPerformanceCollector.java
# Conflicts: # CHANGELOG.md # sentry-android-core/api/sentry-android-core.api # sentry-android-core/src/main/java/io/sentry/android/core/AndroidCpuCollector.java # sentry-android-core/src/main/java/io/sentry/android/core/AndroidOptionsInitializer.java # sentry-android-core/src/test/java/io/sentry/android/core/AndroidCpuCollectorTest.kt # sentry-android-core/src/test/java/io/sentry/android/core/AndroidMemoryCollectorTest.kt # sentry/api/sentry.api # sentry/src/main/java/io/sentry/PerformanceCollectionData.java # sentry/src/main/java/io/sentry/SentryOptions.java # sentry/src/main/java/io/sentry/TransactionPerformanceCollector.java # sentry/src/test/java/io/sentry/JavaMemoryCollectorTest.kt # sentry/src/test/java/io/sentry/TransactionPerformanceCollectorTest.kt
…roid-profiles-cpu-measurement # Conflicts: # sentry-android-core/src/test/java/io/sentry/android/core/AndroidTransactionProfilerTest.kt
stefanosiano
requested review from
adinauer,
romtsn and
markushi
as code owners
Base automatically changed from
feat/android-profiles-memory-measurement
to
main
January 25, 2023 09:54
# Conflicts: # CHANGELOG.md # sentry-android-core/src/main/java/io/sentry/android/core/AndroidTransactionProfiler.java # sentry-android-core/src/test/java/io/sentry/android/core/AndroidTransactionProfilerTest.kt # sentry/src/main/java/io/sentry/profilemeasurements/ProfileMeasurement.java # sentry/src/test/java/io/sentry/JsonSerializerTest.kt
romtsn
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
added cpu usage percentage to profile payload
💡 Motivation and Context
We want to add more data to profiles, so we are including the cpu usage we get from transactions to profile payloads.
Also, at the moment there's no easy way to send the data in the transaction, due to transaction metrics not supporting lists of data. We want to have some data and eventually show it in the Sentry dashboard. The quickest way is to send them in the profiles.
💚 How did you test it?
Unit tests
📝 Checklist
🔮 Next steps
Envelopes are currently not ingested, due to some missing support from relay. Waiting for it to catch up