Prevent OOM by disabling TransactionPerformanceCollector for now #2498
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Extracted
TransactionPerformanceCollector
interface and renamed previousTransactionPerformanceCollector
toDefaultTransactionPerformanceCollector
. UseNoOpTransactionPerformanceCollector
as default inSentryOptions
💡 Motivation and Context
Quick fix for #2496 disabling
TransactionPerformanceCollector
by replacing it with aNoOp
variant.💚 How did you test it?
wrk -t2 -c100 -d30s http://user:password@localhost:8080/person/9
📝 Checklist
sendDefaultPII
is enabled🔮 Next steps
performanceDataMap
isn't cleaned up and keeps growing, then re-enableDefaultTransactionPerformanceCollector