-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add enableTracing
option
#2530
Add enableTracing
option
#2530
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4b32504 | 315.69 ms | 373.96 ms | 58.27 ms |
754021c | 358.70 ms | 361.98 ms | 3.28 ms |
c1399c1 | 345.06 ms | 385.49 ms | 40.43 ms |
5fa24ec | 326.29 ms | 384.53 ms | 58.24 ms |
fe30606 | 310.82 ms | 335.36 ms | 24.55 ms |
f6a135d | 263.96 ms | 383.59 ms | 119.63 ms |
14c083a | 350.82 ms | 388.86 ms | 38.04 ms |
4b32504 | 357.14 ms | 404.04 ms | 46.90 ms |
fe30606 | 327.46 ms | 351.74 ms | 24.28 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
4b32504 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
754021c | 1.73 MiB | 2.33 MiB | 623.06 KiB |
c1399c1 | 1.73 MiB | 2.33 MiB | 620.61 KiB |
5fa24ec | 1.73 MiB | 2.33 MiB | 620.61 KiB |
fe30606 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
f6a135d | 1.73 MiB | 2.33 MiB | 623.10 KiB |
14c083a | 1.73 MiB | 2.33 MiB | 620.61 KiB |
4b32504 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
fe30606 | 1.73 MiB | 2.34 MiB | 623.74 KiB |
Previous results on branch: feat/add-enable-tracing
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d6b4286 | 340.94 ms | 385.46 ms | 44.52 ms |
9a2b68e | 387.20 ms | 444.36 ms | 57.16 ms |
72b2528 | 302.10 ms | 378.77 ms | 76.67 ms |
f7a4308 | 303.88 ms | 325.63 ms | 21.75 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d6b4286 | 1.73 MiB | 2.34 MiB | 623.95 KiB |
9a2b68e | 1.73 MiB | 2.34 MiB | 623.95 KiB |
72b2528 | 1.73 MiB | 2.34 MiB | 624.39 KiB |
f7a4308 | 1.73 MiB | 2.34 MiB | 623.96 KiB |
Codecov ReportBase: 80.20% // Head: 80.21% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #2530 +/- ##
============================================
+ Coverage 80.20% 80.21% +0.01%
- Complexity 3960 3970 +10
============================================
Files 324 324
Lines 14937 14952 +15
Branches 1968 1972 +4
============================================
+ Hits 11980 11994 +14
Misses 2183 2183
- Partials 774 775 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Here's the test for PHP documenting how the options combine: https://github.com/getsentry/sentry-php/pull/1458/files#diff-fa1abff32fd8afc425213dea903ea43386633e2123cc0611c7c2582811d8cffeR631-R653 |
sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
Show resolved
Hide resolved
sentry-samples/sentry-samples-android/src/main/AndroidManifest.xml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of small things, but LGTM otherwise, thanks 🚀
….xml Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
📜 Description
Adds a new
enableTracing
option. If set to true, performance is enabled, even if notracesSampleRate
ortracesSampler
have been configured. For now we set a defaulttracesSampleRate
of1.0
if none has been configured explicitly. IfenableTracing
is set tofalse
performance is disabled, regardless oftracesSampleRate
andtracesSampler
options. The default forenableTracing
isnull
meaning existing behaviour remains unchanged (setting eithertracesSampleRate
ortracesSampler
enables performance)💡 Motivation and Context
Closes #2522
💚 How did you test it?
Unit tests, manually using Android and Spring Boot (Jakarta)
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps