-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter out session cookies sent by Spring and Spring Boot integrations #2593
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3594006 | 318.10 ms | 351.82 ms | 33.72 ms |
0bd502c | 320.20 ms | 358.28 ms | 38.08 ms |
8e355e3 | 340.98 ms | 408.76 ms | 67.78 ms |
f74c07d | 331.85 ms | 367.37 ms | 35.52 ms |
d824f03 | 297.43 ms | 371.58 ms | 74.15 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
3594006 | 1.73 MiB | 2.34 MiB | 626.46 KiB |
0bd502c | 1.73 MiB | 2.34 MiB | 626.25 KiB |
8e355e3 | 1.73 MiB | 2.34 MiB | 626.46 KiB |
f74c07d | 1.73 MiB | 2.34 MiB | 626.25 KiB |
d824f03 | 1.73 MiB | 2.34 MiB | 626.46 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2593 +/- ##
============================================
- Coverage 81.17% 81.16% -0.01%
- Complexity 4102 4125 +23
============================================
Files 333 333
Lines 15213 15329 +116
Branches 1980 1995 +15
============================================
+ Hits 12349 12442 +93
- Misses 2084 2101 +17
- Partials 780 786 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an observation, feel free to ignore
📜 Description
Replace values of certain cookies that could allow impersonation with
[Filtered]
and do not send the value to Sentry.💡 Motivation and Context
Fixes #2562
💚 How did you test it?
Unit Tests, manually using samples
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps