Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read integration list written by sentry gradle plugin from manifest #2598

Merged
merged 11 commits into from
Mar 23, 2023

Conversation

lbloder
Copy link
Collaborator

@lbloder lbloder commented Mar 10, 2023

📜 Description

Reads integration list from manifest

💡 Motivation and Context

Reads information provided by getsentry/sentry-android-gradle-plugin#441
Enhances #2179

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 603ab08

@github-actions
Copy link
Contributor

github-actions bot commented Mar 10, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 315.27 ms 390.54 ms 75.28 ms
Size 1.73 MiB 2.26 MiB 547.78 KiB

Previous results on branch: feat/read_integration_list_from_manifest

Startup times

Revision Plain With Sentry Diff
f5bb9da 323.52 ms 373.69 ms 50.17 ms
f001a34 319.89 ms 343.00 ms 23.11 ms
2fa66aa 294.69 ms 372.22 ms 77.53 ms
1019356 336.26 ms 426.40 ms 90.14 ms
05c4413 308.56 ms 368.82 ms 60.26 ms
95fa2b2 393.98 ms 499.26 ms 105.28 ms
747dea1 356.27 ms 404.69 ms 48.43 ms

App size

Revision Plain With Sentry Diff
f5bb9da 1.73 MiB 2.34 MiB 626.62 KiB
f001a34 1.73 MiB 2.34 MiB 626.26 KiB
2fa66aa 1.73 MiB 2.34 MiB 626.32 KiB
1019356 1.73 MiB 2.34 MiB 626.62 KiB
05c4413 1.73 MiB 2.34 MiB 625.91 KiB
95fa2b2 1.73 MiB 2.34 MiB 625.87 KiB
747dea1 1.73 MiB 2.34 MiB 626.49 KiB

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (8ec2c16) 81.31% compared to head (603ab08) 81.31%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2598   +/-   ##
=========================================
  Coverage     81.31%   81.31%           
  Complexity     4187     4187           
=========================================
  Files           336      336           
  Lines         15485    15485           
  Branches       2020     2020           
=========================================
  Hits          12591    12591           
  Misses         2101     2101           
  Partials        793      793           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is probably not up-to-date with main? Shouldn't show up in this PR in theory

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will check the gradle plugin PR soon 👍 thanks

lbloder and others added 2 commits March 23, 2023 09:18
…estMetadataReader.java

Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
@lbloder lbloder marked this pull request as ready for review March 23, 2023 09:16
@lbloder lbloder merged commit d81684e into main Mar 23, 2023
@lbloder lbloder deleted the feat/read_integration_list_from_manifest branch March 23, 2023 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants