-
-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read integration list written by sentry gradle plugin from manifest #2598
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f5bb9da | 323.52 ms | 373.69 ms | 50.17 ms |
f001a34 | 319.89 ms | 343.00 ms | 23.11 ms |
2fa66aa | 294.69 ms | 372.22 ms | 77.53 ms |
1019356 | 336.26 ms | 426.40 ms | 90.14 ms |
05c4413 | 308.56 ms | 368.82 ms | 60.26 ms |
95fa2b2 | 393.98 ms | 499.26 ms | 105.28 ms |
747dea1 | 356.27 ms | 404.69 ms | 48.43 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
f5bb9da | 1.73 MiB | 2.34 MiB | 626.62 KiB |
f001a34 | 1.73 MiB | 2.34 MiB | 626.26 KiB |
2fa66aa | 1.73 MiB | 2.34 MiB | 626.32 KiB |
1019356 | 1.73 MiB | 2.34 MiB | 626.62 KiB |
05c4413 | 1.73 MiB | 2.34 MiB | 625.91 KiB |
95fa2b2 | 1.73 MiB | 2.34 MiB | 625.87 KiB |
747dea1 | 1.73 MiB | 2.34 MiB | 626.49 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2598 +/- ##
=========================================
Coverage 81.31% 81.31%
Complexity 4187 4187
=========================================
Files 336 336
Lines 15485 15485
Branches 2020 2020
=========================================
Hits 12591 12591
Misses 2101 2101
Partials 793 793 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
# Conflicts: # CHANGELOG.md
sentry-android-core/src/main/java/io/sentry/android/core/ManifestMetadataReader.java
Outdated
Show resolved
Hide resolved
sentry-android-ndk/sentry-native
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is probably not up-to-date with main
? Shouldn't show up in this PR in theory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, will check the gradle plugin PR soon 👍 thanks
…estMetadataReader.java Co-authored-by: Roman Zavarnitsyn <rom4ek93@gmail.com>
📜 Description
Reads integration list from manifest
💡 Motivation and Context
Reads information provided by getsentry/sentry-android-gradle-plugin#441
Enhances #2179
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps