Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add time-to-initial-display and time-to-full-display measurements to Activity transactions #2611

Merged
merged 8 commits into from
Mar 24, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

Added ttid and ttfd as measurements
Added getStartDate() to ISpan
Fixed ActivityLifecycleIntegration tests

💡 Motivation and Context

Currently we track time-to-initial-display and time-to-full-display as spans on automatic activity transactions.
Now we add them as measurements, too.
More info here.

💚 How did you test it?

Unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

added getStartDate() to ISpan
fixed ActivityLifecycleIntegration tests
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 800c092

@stefanosiano stefanosiano changed the title Add time-to-initial-display and time-to-full-display measurements Add time-to-initial-display and time-to-full-display measurements to Activity transactions Mar 17, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 17, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 296.48 ms 352.24 ms 55.76 ms
Size 1.73 MiB 2.26 MiB 548.04 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d81684e 235.73 ms 328.76 ms 93.03 ms

App size

Revision Plain With Sentry Diff
d81684e 1.73 MiB 2.26 MiB 547.78 KiB

Previous results on branch: feat/ttid-tffd-measurements

Startup times

Revision Plain With Sentry Diff
97f2094 448.31 ms 498.76 ms 50.45 ms
55a1e65 311.44 ms 339.21 ms 27.77 ms
6939df1 311.71 ms 389.82 ms 78.11 ms

App size

Revision Plain With Sentry Diff
97f2094 1.73 MiB 2.26 MiB 548.02 KiB
55a1e65 1.73 MiB 2.26 MiB 548.03 KiB
6939df1 1.73 MiB 2.26 MiB 547.98 KiB

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (d81684e) 81.31% compared to head (800c092) 81.31%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2611   +/-   ##
=========================================
  Coverage     81.31%   81.31%           
- Complexity     4187     4189    +2     
=========================================
  Files           336      336           
  Lines         15485    15487    +2     
  Branches       2020     2020           
=========================================
+ Hits          12591    12593    +2     
  Misses         2101     2101           
  Partials        793      793           
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/SentryTracer.java 93.35% <ø> (ø)
sentry/src/main/java/io/sentry/Span.java 89.55% <ø> (ø)
...main/java/io/sentry/protocol/MeasurementValue.java 94.23% <ø> (ø)
sentry/src/main/java/io/sentry/NoOpSpan.java 25.00% <100.00%> (+2.41%) ⬆️
...entry/src/main/java/io/sentry/NoOpTransaction.java 24.44% <100.00%> (+1.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@stefanosiano stefanosiano marked this pull request as ready for review March 17, 2023 16:58
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a couple of minor comments, but LGTM 🚀

@romtsn
Copy link
Member

romtsn commented Mar 24, 2023

checked again, looking good :shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants