-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add time-to-initial-display and time-to-full-display measurements to Activity transactions #2611
Conversation
added getStartDate() to ISpan fixed ActivityLifecycleIntegration tests
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
Previous results on branch: feat/ttid-tffd-measurements
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
97f2094 | 448.31 ms | 498.76 ms | 50.45 ms |
55a1e65 | 311.44 ms | 339.21 ms | 27.77 ms |
6939df1 | 311.71 ms | 389.82 ms | 78.11 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
97f2094 | 1.73 MiB | 2.26 MiB | 548.02 KiB |
55a1e65 | 1.73 MiB | 2.26 MiB | 548.03 KiB |
6939df1 | 1.73 MiB | 2.26 MiB | 547.98 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2611 +/- ##
=========================================
Coverage 81.31% 81.31%
- Complexity 4187 4189 +2
=========================================
Files 336 336
Lines 15485 15487 +2
Branches 2020 2020
=========================================
+ Hits 12591 12593 +2
Misses 2101 2101
Partials 793 793
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
sentry-android-core/src/main/java/io/sentry/android/core/ActivityLifecycleIntegration.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of minor comments, but LGTM 🚀
changed duration measurements to milliseconds
removed measurement keys magic strings from tests
checked again, looking good |
📜 Description
Added ttid and ttfd as measurements
Added getStartDate() to ISpan
Fixed ActivityLifecycleIntegration tests
💡 Motivation and Context
Currently we track time-to-initial-display and time-to-full-display as spans on automatic activity transactions.
Now we add them as measurements, too.
More info here.
💚 How did you test it?
Unit tests
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps