Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create User and Breadcrumb from map #2614

Merged
merged 21 commits into from
Apr 17, 2023
Merged

Conversation

denrase
Copy link
Collaborator

@denrase denrase commented Mar 21, 2023

📜 Description

Create User and Breadcrumb from map.

💡 Motivation and Context

Closes #2534

💚 How did you test it?

Added unit tests.

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@denrase denrase changed the title Feat/user and breadcrumb from map Create User and Breadcrumb from map Mar 21, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5517ba7

@github-actions
Copy link
Contributor

github-actions bot commented Mar 21, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 297.40 ms 352.79 ms 55.39 ms
Size 1.73 MiB 2.26 MiB 550.38 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
33c80c7 318.88 ms 348.14 ms 29.26 ms
17ab223 427.65 ms 484.31 ms 56.65 ms
d81684e 235.73 ms 328.76 ms 93.03 ms
33c80c7 331.94 ms 370.54 ms 38.60 ms

App size

Revision Plain With Sentry Diff
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB
17ab223 1.73 MiB 2.34 MiB 626.85 KiB
d81684e 1.73 MiB 2.26 MiB 547.78 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB

Previous results on branch: feat/user-and-breadcrumb-from-map

Startup times

Revision Plain With Sentry Diff
c95386d 344.45 ms 360.29 ms 15.84 ms
2c304d6 321.66 ms 372.60 ms 50.94 ms
63e2cbd 269.02 ms 345.04 ms 76.02 ms
95fa2f7 301.00 ms 310.72 ms 9.72 ms
f78960e 312.00 ms 359.80 ms 47.80 ms
e8affdd 302.08 ms 381.08 ms 79.00 ms
2adb1c5 292.02 ms 338.50 ms 46.48 ms

App size

Revision Plain With Sentry Diff
c95386d 1.73 MiB 2.26 MiB 547.66 KiB
2c304d6 1.73 MiB 2.26 MiB 548.10 KiB
63e2cbd 1.73 MiB 2.26 MiB 548.11 KiB
95fa2f7 1.73 MiB 2.26 MiB 547.66 KiB
f78960e 1.73 MiB 2.26 MiB 548.11 KiB
e8affdd 1.73 MiB 2.26 MiB 551.45 KiB
2adb1c5 1.73 MiB 2.26 MiB 551.44 KiB

@codecov
Copy link

codecov bot commented Mar 21, 2023

Codecov Report

Patch coverage: 59.16% and project coverage change: -0.16 ⚠️

Comparison is base (e5871b9) 81.40% compared to head (5517ba7) 81.25%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2614      +/-   ##
============================================
- Coverage     81.40%   81.25%   -0.16%     
- Complexity     4227     4259      +32     
============================================
  Files           337      337              
  Lines         15622    15741     +119     
  Branches       2039     2079      +40     
============================================
+ Hits          12717    12790      +73     
- Misses         2111     2130      +19     
- Partials        794      821      +27     
Impacted Files Coverage Δ
...ntry/src/main/java/io/sentry/JsonObjectReader.java 78.04% <33.33%> (-1.96%) ⬇️
sentry/src/main/java/io/sentry/protocol/User.java 76.54% <49.12%> (-12.99%) ⬇️
sentry/src/main/java/io/sentry/protocol/Geo.java 83.33% <66.66%> (+1.85%) ⬆️
sentry/src/main/java/io/sentry/Breadcrumb.java 82.74% <70.83%> (-3.22%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@denrase denrase marked this pull request as ready for review March 27, 2023 16:24
@denrase denrase requested a review from romtsn March 28, 2023 09:49
Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks 👍 just a reminder to also add handling for GEO and NAME after your other PR is merged in:

  • Add handling for Geo and Name of User

@denrase
Copy link
Collaborator Author

denrase commented Apr 17, 2023

Are we rdy we merge or is anything missing here?

@romtsn
Copy link
Member

romtsn commented Apr 17, 2023

Are we rdy we merge or is anything missing here?

CI is red, but good to merge otherwise :)

@denrase
Copy link
Collaborator Author

denrase commented Apr 17, 2023

@romtsn There seem to be some timeouts on CI which should not relate to the code. Are those known?

@romtsn
Copy link
Member

romtsn commented Apr 17, 2023

@romtsn There seem to be some timeouts on CI which should not relate to the code. Are those known?

yeah it's just saucelabs being flaky.. I'm gonna merge this

@romtsn romtsn merged commit c9d0787 into main Apr 17, 2023
@romtsn romtsn deleted the feat/user-and-breadcrumb-from-map branch April 17, 2023 12:50
@denrase
Copy link
Collaborator Author

denrase commented Apr 18, 2023

Just for reference. Relates to getsentry/sentry-dart#1330

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create User and Breadcrumb data classes from a Map
3 participants