Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide CPU count/frequency data as device context #2622

Merged
merged 9 commits into from
Mar 29, 2023

Conversation

markushi
Copy link
Member

📜 Description

Adds CPU description, processor count and frequency to the device context.

💡 Motivation and Context

Implements required changes for #2561

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 7079193

@github-actions
Copy link
Contributor

github-actions bot commented Mar 24, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 281.72 ms 309.81 ms 28.09 ms
Size 1.73 MiB 2.34 MiB 627.33 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d81684e 235.73 ms 328.76 ms 93.03 ms

App size

Revision Plain With Sentry Diff
d81684e 1.73 MiB 2.26 MiB 547.78 KiB

Previous results on branch: feat/cpu-info-for-device-context

Startup times

Revision Plain With Sentry Diff
b87c189 277.96 ms 333.42 ms 55.46 ms
d39f310 301.85 ms 341.92 ms 40.07 ms
5d9e93d 326.30 ms 352.68 ms 26.38 ms
b2056ee 282.14 ms 340.54 ms 58.40 ms

App size

Revision Plain With Sentry Diff
b87c189 1.73 MiB 2.26 MiB 548.06 KiB
d39f310 1.73 MiB 2.26 MiB 548.06 KiB
5d9e93d 1.73 MiB 2.26 MiB 548.23 KiB
b2056ee 1.73 MiB 2.26 MiB 548.75 KiB

@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.02 🎉

Comparison is base (17ab223) 81.34% compared to head (7079193) 81.37%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2622      +/-   ##
============================================
+ Coverage     81.34%   81.37%   +0.02%     
- Complexity     4211     4219       +8     
============================================
  Files           337      337              
  Lines         15575    15599      +24     
  Branches       2034     2037       +3     
============================================
+ Hits          12670    12693      +23     
- Misses         2110     2111       +1     
  Partials        795      795              
Impacted Files Coverage Δ
...entry/src/main/java/io/sentry/protocol/Device.java 96.51% <100.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@markushi
Copy link
Member Author

Waiting for feedback, see getsentry/team-mobile#77 (comment)

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just a couple minor comments

@markushi markushi merged commit 6641771 into main Mar 29, 2023
@markushi markushi deleted the feat/cpu-info-for-device-context branch March 29, 2023 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants