-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide CPU count/frequency data as device context #2622
Conversation
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d81684e | 235.73 ms | 328.76 ms | 93.03 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
d81684e | 1.73 MiB | 2.26 MiB | 547.78 KiB |
Previous results on branch: feat/cpu-info-for-device-context
Startup times
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b87c189 | 277.96 ms | 333.42 ms | 55.46 ms |
d39f310 | 301.85 ms | 341.92 ms | 40.07 ms |
5d9e93d | 326.30 ms | 352.68 ms | 26.38 ms |
b2056ee | 282.14 ms | 340.54 ms | 58.40 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
b87c189 | 1.73 MiB | 2.26 MiB | 548.06 KiB |
d39f310 | 1.73 MiB | 2.26 MiB | 548.06 KiB |
5d9e93d | 1.73 MiB | 2.26 MiB | 548.23 KiB |
b2056ee | 1.73 MiB | 2.26 MiB | 548.75 KiB |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #2622 +/- ##
============================================
+ Coverage 81.34% 81.37% +0.02%
- Complexity 4211 4219 +8
============================================
Files 337 337
Lines 15575 15599 +24
Branches 2034 2037 +3
============================================
+ Hits 12670 12693 +23
- Misses 2110 2111 +1
Partials 795 795
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Waiting for feedback, see getsentry/team-mobile#77 (comment) |
sentry-android-core/src/main/java/io/sentry/android/core/DefaultAndroidEventProcessor.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just a couple minor comments
📜 Description
Adds CPU description, processor count and frequency to the device context.
💡 Motivation and Context
Implements required changes for #2561
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps