Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hub.close using withScope and not configureScope #2688

Merged
merged 4 commits into from
May 2, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented May 2, 2023

📜 Description

#2679 (comment)

💡 Motivation and Context

Noticed while reviewing #2679

💚 How did you test it?

With a test that was failing prior to the fix

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented May 2, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 349.15 ms 366.48 ms 17.33 ms
Size 1.72 MiB 2.26 MiB 553.42 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
33c80c7 331.94 ms 370.54 ms 38.60 ms
d81684e 235.73 ms 328.76 ms 93.03 ms
17ab223 427.65 ms 484.31 ms 56.65 ms
33c80c7 318.88 ms 348.14 ms 29.26 ms

App size

Revision Plain With Sentry Diff
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB
d81684e 1.73 MiB 2.26 MiB 547.78 KiB
17ab223 1.73 MiB 2.34 MiB 626.85 KiB
33c80c7 1.73 MiB 2.26 MiB 551.46 KiB

Previous results on branch: rz/fix/configure-scope

Startup times

Revision Plain With Sentry Diff
2380724 314.90 ms 367.96 ms 53.06 ms

App size

Revision Plain With Sentry Diff
2380724 1.72 MiB 2.26 MiB 553.42 KiB

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.02 ⚠️

Comparison is base (4d00bb3) 81.33% compared to head (8f96196) 81.32%.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2688      +/-   ##
============================================
- Coverage     81.33%   81.32%   -0.02%     
  Complexity     4271     4271              
============================================
  Files           337      337              
  Lines         15795    15795              
  Branches       2083     2083              
============================================
- Hits          12847    12845       -2     
- Misses         2125     2127       +2     
  Partials        823      823              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Hub.java 76.51% <100.00%> (-0.49%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@romtsn romtsn merged commit b03d10f into main May 2, 2023
@romtsn romtsn deleted the rz/fix/configure-scope branch May 2, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants