-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure AppStart time till First Draw #2851
Conversation
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/7.0.0 #2851 +/- ##
================================================
+ Coverage 81.26% 81.41% +0.15%
- Complexity 4560 4644 +84
================================================
Files 350 354 +4
Lines 16866 17106 +240
Branches 2272 2313 +41
================================================
+ Hits 13706 13927 +221
- Misses 2219 2230 +11
- Partials 941 949 +8
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
everything looks good
i was thinking to add the considerations in https://blog.p-y.wtf/tracking-android-app-launch-in-production#heading-cold-launch-1, since sometime (rarely) the start timestamp we get is wrong and we are changing the related code
We can do that in another pr, too
yes, I'd do it in a separate PR, and we also have an issue for that specifically #2177 |
📜 Description
ActivityLifecycleIntegration
andSentryPerformanceProvider
💡 Motivation and Context
Closes #2627
💚 How did you test it?
Manually and automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps