Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not overwrite UI transaction status if set by the user #2852

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Jul 19, 2023

📜 Description

Do not overwrite UI transaction status if set by the user

💡 Motivation and Context

Closes #2378

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 19, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 280.50 ms 324.98 ms 44.48 ms
Size 1.72 MiB 2.29 MiB 575.30 KiB

@codecov
Copy link

codecov bot commented Jul 19, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (9020d1b) 81.26% compared to head (a1454e7) 81.31%.

Additional details and impacted files
@@               Coverage Diff                @@
##             feat/7.0.0    #2852      +/-   ##
================================================
+ Coverage         81.26%   81.31%   +0.04%     
- Complexity         4560     4564       +4     
================================================
  Files               350      351       +1     
  Lines             16866    16867       +1     
  Branches           2272     2272              
================================================
+ Hits              13706    13715       +9     
+ Misses             2219     2211       -8     
  Partials            941      941              
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Hub.java 75.17% <ø> (ø)
sentry/src/main/java/io/sentry/SentryOptions.java 80.70% <ø> (+0.74%) ⬆️
sentry/src/main/java/io/sentry/SentryTracer.java 94.98% <100.00%> (+0.01%) ⬆️
...ry/src/main/java/io/sentry/util/LazyEvaluator.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@romtsn romtsn merged commit cae0eea into feat/7.0.0 Jul 20, 2023
@romtsn romtsn deleted the rz/fix/ui-event-txs-status branch July 20, 2023 07:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants