-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set ip_address = {{auto}} by default #2860
Conversation
For disabling: The project configuration has a toggle to disable storing the IP address.
|
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/7.0.0 #2860 +/- ##
================================================
+ Coverage 81.26% 81.32% +0.05%
- Complexity 4560 4564 +4
================================================
Files 350 351 +1
Lines 16866 16866
Branches 2272 2272
================================================
+ Hits 13706 13716 +10
+ Misses 2219 2210 -9
+ Partials 941 940 -1
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, even the changelog comment 👍
📜 Description
For disabling: The project configuration has a toggle to disable storing
the IP address.
💡 Motivation and Context
Fixes #2850
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps