Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set ip_address = {{auto}} by default #2860

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

markushi
Copy link
Member

📜 Description

For disabling: The project configuration has a toggle to disable storing
the IP address.

💡 Motivation and Context

Fixes #2850

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

For disabling: The project configuration has a toggle to disable storing
the IP address.
@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 87e3ecb

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 296.06 ms 346.56 ms 50.50 ms
Size 1.72 MiB 2.29 MiB 575.32 KiB

Previous results on branch: feat/user-default-ip

Startup times

Revision Plain With Sentry Diff
0972845 279.98 ms 316.56 ms 36.58 ms
a3076d4 293.04 ms 378.67 ms 85.63 ms

App size

Revision Plain With Sentry Diff
0972845 1.72 MiB 2.29 MiB 575.29 KiB
a3076d4 1.72 MiB 2.29 MiB 575.29 KiB

@codecov
Copy link

codecov bot commented Jul 21, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.05 🎉

Comparison is base (9020d1b) 81.26% compared to head (87e3ecb) 81.32%.

Additional details and impacted files
@@               Coverage Diff                @@
##             feat/7.0.0    #2860      +/-   ##
================================================
+ Coverage         81.26%   81.32%   +0.05%     
- Complexity         4560     4564       +4     
================================================
  Files               350      351       +1     
  Lines             16866    16866              
  Branches           2272     2272              
================================================
+ Hits              13706    13716      +10     
+ Misses             2219     2210       -9     
+ Partials            941      940       -1     
Impacted Files Coverage Δ
sentry/src/main/java/io/sentry/Hub.java 75.17% <ø> (ø)
sentry/src/main/java/io/sentry/SentryOptions.java 80.70% <ø> (+0.74%) ⬆️
...ry/src/main/java/io/sentry/MainEventProcessor.java 88.59% <100.00%> (+1.25%) ⬆️
sentry/src/main/java/io/sentry/SentryTracer.java 94.98% <100.00%> (+0.01%) ⬆️
...y/src/main/java/io/sentry/cache/EnvelopeCache.java 65.36% <100.00%> (ø)
...ry/src/main/java/io/sentry/util/LazyEvaluator.java 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, even the changelog comment 👍

@markushi markushi merged commit 19fca04 into feat/7.0.0 Jul 24, 2023
17 checks passed
@markushi markushi deleted the feat/user-default-ip branch July 24, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants