-
-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add autoconfigure modules for Spring Boot called sentry-spring-boot
and sentry-spring-boot-jakarta
#2880
Conversation
… sentry-spring-boot-starter bring spring-boot-starter
sentry-spring-boot
and sentry-spring-boot-jakarta
|
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
496bdfd | 301.22 ms | 343.96 ms | 42.73 ms |
fe10f05 | 314.71 ms | 360.62 ms | 45.90 ms |
fe10f05 | 304.13 ms | 365.65 ms | 61.52 ms |
f60279b | 324.60 ms | 345.33 ms | 20.73 ms |
496bdfd | 272.86 ms | 407.33 ms | 134.48 ms |
9246ed4 | 275.63 ms | 321.31 ms | 45.69 ms |
87b3774 | 310.48 ms | 362.04 ms | 51.56 ms |
4bf202b | 331.20 ms | 345.24 ms | 14.04 ms |
fe10f05 | 294.30 ms | 346.84 ms | 52.54 ms |
4c237f8 | 319.84 ms | 354.47 ms | 34.63 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
fe10f05 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
fe10f05 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
f60279b | 1.72 MiB | 2.29 MiB | 575.23 KiB |
496bdfd | 1.72 MiB | 2.28 MiB | 571.82 KiB |
9246ed4 | 1.72 MiB | 2.28 MiB | 572.22 KiB |
87b3774 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
4bf202b | 1.72 MiB | 2.29 MiB | 575.54 KiB |
fe10f05 | 1.72 MiB | 2.29 MiB | 575.54 KiB |
4c237f8 | 1.72 MiB | 2.29 MiB | 575.58 KiB |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #2880 +/- ##
=========================================
Coverage 80.45% 80.45%
Complexity 4701 4701
=========================================
Files 371 371
Lines 17556 17556
Branches 2364 2364
=========================================
Hits 14125 14125
Misses 2454 2454
Partials 977 977
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
So, existing users of the spring-boot integration would need to change their dependency from sentry-spring-boot -starter
to just sentry-spring-boot
, correct?
It should work with either the |
📜 Description
Rename
sentry-spring-boot-starter
tosentry-spring-boot
which is now our "autoconfigure" module that has acompileOnly
dependency onspring-boot-starter
. Add a newsentry-spring-boot-starter
module that depends onsentry-spring-boot
as well asspring-boot-starter
. Same changes forjakarta
packages.💡 Motivation and Context
Fixes #2866
💚 How did you test it?
Manually
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps