Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump min API to 19 #2883

Merged
merged 3 commits into from
Aug 16, 2023
Merged

Bump min API to 19 #2883

merged 3 commits into from
Aug 16, 2023

Conversation

stefanosiano
Copy link
Member

📜 Description

updated minimum Android SDK version to 19
removed few workarounds for version < 19

💡 Motivation and Context

Fixes #2126

💚 How did you test it?

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

removed few workarounds for version < 19
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 99deaff

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 304.29 ms 356.92 ms 52.63 ms
Size 1.72 MiB 2.26 MiB 548.02 KiB

Previous results on branch: feat/bump_api_19

Startup times

Revision Plain With Sentry Diff
cb15e94 261.45 ms 343.18 ms 81.73 ms

App size

Revision Plain With Sentry Diff
cb15e94 1.72 MiB 2.26 MiB 547.06 KiB

@codecov
Copy link

codecov bot commented Aug 4, 2023

Codecov Report

Patch coverage: 86.33% and project coverage change: +0.19% 🎉

Comparison is base (9020d1b) 81.26% compared to head (99deaff) 81.45%.
Report is 45 commits behind head on feat/7.0.0.

Additional details and impacted files
@@               Coverage Diff                @@
##             feat/7.0.0    #2883      +/-   ##
================================================
+ Coverage         81.26%   81.45%   +0.19%     
- Complexity         4560     4661     +101     
================================================
  Files               350      354       +4     
  Lines             16866    17155     +289     
  Branches           2272     2321      +49     
================================================
+ Hits              13706    13974     +268     
- Misses             2219     2231      +12     
- Partials            941      950       +9     
Files Changed Coverage Δ
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
...ebflux/SentryWebFilterWithThreadLocalAccessor.java 0.00% <0.00%> (ø)
...racing/SentrySpanClientHttpRequestInterceptor.java 0.00% <0.00%> (ø)
sentry/src/main/java/io/sentry/Breadcrumb.java 85.04% <ø> (ø)
sentry/src/main/java/io/sentry/HostnameCache.java 90.69% <ø> (ø)
sentry/src/main/java/io/sentry/Hub.java 75.17% <ø> (ø)
.../src/main/java/io/sentry/JsonObjectSerializer.java 84.21% <ø> (ø)
...ry/src/main/java/io/sentry/ProfilingTraceData.java 78.51% <ø> (ø)
.../main/java/io/sentry/ProfilingTransactionData.java 52.52% <ø> (ø)
sentry/src/main/java/io/sentry/Scope.java 96.72% <0.00%> (-0.36%) ⬇️
... and 81 more

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stefanosiano stefanosiano marked this pull request as ready for review August 4, 2023 13:24
Copy link
Member

@markushi markushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stefanosiano stefanosiano merged commit b0e93e8 into feat/7.0.0 Aug 16, 2023
@stefanosiano stefanosiano deleted the feat/bump_api_19 branch August 16, 2023 11:38
@romtsn romtsn mentioned this pull request Aug 16, 2023
val minSdkVersionOkHttp = 21
val minSdkVersionNdk = 16
val minSdkVersionNdk = 19
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minSdkVersionNdk can be removed since its the same now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants