-
-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump min API to 19 #2883
Bump min API to 19 #2883
Conversation
removed few workarounds for version < 19
|
Performance metrics 🚀
|
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feat/7.0.0 #2883 +/- ##
================================================
+ Coverage 81.26% 81.45% +0.19%
- Complexity 4560 4661 +101
================================================
Files 350 354 +4
Lines 16866 17155 +289
Branches 2272 2321 +49
================================================
+ Hits 13706 13974 +268
- Misses 2219 2231 +12
- Partials 941 950 +9
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sentry-android-core/src/main/java/io/sentry/android/core/internal/util/ScreenshotUtils.java
Outdated
Show resolved
Hide resolved
val minSdkVersionOkHttp = 21 | ||
val minSdkVersionNdk = 16 | ||
val minSdkVersionNdk = 19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minSdkVersionNdk
can be removed since its the same now.
📜 Description
updated minimum Android SDK version to 19
removed few workarounds for version < 19
💡 Motivation and Context
Fixes #2126
💚 How did you test it?
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps