Send http.request.method in span data

[adinauer]

📜 Description

Send http.request.method in span data

💡 Motivation and Context

See getsentry/team-sdks#20

💚 How did you test it?

Unit Tests + Manually

📝 Checklist

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[github-actions]

	Messages
📖	Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 5bc1a83

[github-actions]

Performance metrics 🚀

	Plain	With Sentry	Diff
Startup time	315.69 ms	366.80 ms	51.11 ms
Size	1.72 MiB	2.29 MiB	575.74 KiB

Baseline results on branch: main

Startup times

Revision	Plain	With Sentry	Diff
c03a05e	390.40 ms	419.35 ms	28.94 ms
4c237f8	319.84 ms	354.47 ms	34.63 ms
8820c5c	330.60 ms	416.86 ms	86.26 ms
0310da5	381.20 ms	404.50 ms	23.30 ms
496bdfd	301.22 ms	343.96 ms	42.73 ms
caf50ec	302.36 ms	325.25 ms	22.89 ms
9246ed4	281.79 ms	352.08 ms	70.29 ms
fe10f05	294.30 ms	346.84 ms	52.54 ms
adf8fe3	300.49 ms	357.36 ms	56.87 ms
fe10f05	314.71 ms	360.62 ms	45.90 ms

App size

Revision	Plain	With Sentry	Diff
c03a05e	1.72 MiB	2.29 MiB	574.43 KiB
4c237f8	1.72 MiB	2.29 MiB	575.58 KiB
8820c5c	1.72 MiB	2.28 MiB	571.82 KiB
0310da5	1.72 MiB	2.28 MiB	573.45 KiB
496bdfd	1.72 MiB	2.28 MiB	571.82 KiB
caf50ec	1.72 MiB	2.29 MiB	575.24 KiB
9246ed4	1.72 MiB	2.28 MiB	572.22 KiB
fe10f05	1.72 MiB	2.29 MiB	575.54 KiB
adf8fe3	1.72 MiB	2.29 MiB	575.24 KiB
fe10f05	1.72 MiB	2.29 MiB	575.54 KiB

Previous results on branch: feat/http-method-span-data

Startup times

Revision	Plain	With Sentry	Diff
4bca198	302.45 ms	347.14 ms	44.69 ms
5553c62	303.56 ms	382.04 ms	78.48 ms
0e8dcf6	329.21 ms	385.28 ms	56.07 ms

App size

Revision	Plain	With Sentry	Diff
4bca198	1.72 MiB	2.29 MiB	575.74 KiB
5553c62	1.72 MiB	2.29 MiB	575.74 KiB
0e8dcf6	1.72 MiB	2.29 MiB	575.74 KiB

[codecov]

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.01% ⚠️

Comparison is base (3fe387a) 79.61% compared to head (5bc1a83) 79.61%.
Report is 2 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff              @@
##               main    #2896      +/-   ##
============================================
- Coverage     79.61%   79.61%   -0.01%     
  Complexity     6038     6038              
============================================
  Files           469      469              
  Lines         23294    23307      +13     
  Branches       3176     3177       +1     
============================================
+ Hits          18545    18555      +10     
- Misses         3353     3355       +2     
- Partials       1396     1397       +1     

Files Changed	Coverage Δ
...racing/SentrySpanClientHttpRequestInterceptor.java	0.00% <0.00%> (ø)
...racing/SentrySpanClientHttpRequestInterceptor.java	0.00% <0.00%> (ø)
...n/java/io/sentry/apollo/SentryApolloInterceptor.kt	82.69% <80.00%> (-0.14%)	⬇️
...java/io/sentry/android/okhttp/SentryOkHttpEvent.kt	88.15% <100.00%> (ø)
.../io/sentry/apollo3/SentryApollo3HttpInterceptor.kt	84.27% <100.00%> (ø)
...in/java/io/sentry/openfeign/SentryFeignClient.java	96.20% <100.00%> (+0.09%)	⬆️
...arta/tracing/SentrySpanClientWebRequestFilter.java	75.92% <100.00%> (+0.92%)	⬆️
...ring/tracing/SentrySpanClientWebRequestFilter.java	78.18% <100.00%> (+0.82%)	⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[stefanosiano]

looks good!
would you mind changing okhttp and its test too?
So everything is aligned with the method being uppercase (a simple method.uppercase(Locale.ROOT) is enough)

[lbloder]

Looks good.
Maybe we should also change the original SentryApolloInterceptor to add the http.request.method ?

[lbloder]

LGTM 👍