Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SentryCheckIn annotation and advice config for Spring #2946

Merged
merged 28 commits into from
Sep 27, 2023

Conversation

adinauer
Copy link
Member

📜 Description

The @SentryCheckIn annotation can be put on methods in Spring applications, sending check-ins for that method.
This can for example be combined with @Scheduled methods.

💡 Motivation and Context

Support for @Scheduled in Spring

💚 How did you test it?

manually

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- SentryCheckIn annotation and advice config for Spring ([#2946](https://github.com/getsentry/sentry-java/pull/2946))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 8179966

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 448.02 ms 528.94 ms 80.92 ms
Size 1.72 MiB 2.29 MiB 575.99 KiB

Baseline results on branch: feat/crons-lib-support

Startup times

Revision Plain With Sentry Diff
5894625 378.40 ms 424.38 ms 45.98 ms

App size

Revision Plain With Sentry Diff
5894625 1.72 MiB 2.29 MiB 575.99 KiB

Previous results on branch: feat/crons-spring-scheduled

Startup times

Revision Plain With Sentry Diff
c11b373 274.50 ms 309.04 ms 34.54 ms
a59fe55 351.31 ms 451.24 ms 99.93 ms
24b1f58 394.88 ms 467.82 ms 72.94 ms

App size

Revision Plain With Sentry Diff
c11b373 1.72 MiB 2.29 MiB 575.99 KiB
a59fe55 1.72 MiB 2.29 MiB 576.09 KiB
24b1f58 1.72 MiB 2.29 MiB 575.99 KiB

@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

📢 Thoughts on this report? Let us know!.

@adinauer adinauer changed the title SentryCheckIn annotation and advice config for jakarta SentryCheckIn annotation and advice config for Spring Sep 25, 2023
@adinauer adinauer self-assigned this Sep 25, 2023
Base automatically changed from feat/crons-experimental to feat/crons-lib-support September 25, 2023 12:41
@smeubank smeubank linked an issue Sep 26, 2023 that may be closed by this pull request
Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could add a test similar to the SentryTransactionAdviceTest.

added comments regarding the scope of the annotation

Copy link
Collaborator

@lbloder lbloder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some wording suggestions.

Otherwise LGTM 👍

Co-authored-by: Lukas Bloder <lukas.bloder@gmail.com>
@adinauer adinauer merged commit d639a33 into feat/crons-lib-support Sep 27, 2023
10 of 14 checks passed
@adinauer adinauer deleted the feat/crons-spring-scheduled branch September 27, 2023 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crons support for Java
2 participants