Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Activity Breadcrumbs generation into own Integration #3064

Merged
merged 22 commits into from
Dec 18, 2023

Conversation

markushi
Copy link
Member

📜 Description

Our ActivityLifecycleIntegration is doing a lot, in order to make future changes easier, let's extract some functionality out of it.

💚 How did you test it?

Added / extracted unit tests

📝 Checklist

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Nov 27, 2023

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 4077bae

Copy link
Contributor

github-actions bot commented Nov 27, 2023

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 411.08 ms 437.45 ms 26.37 ms
Size 1.72 MiB 2.27 MiB 557.19 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
93a76ca 377.96 ms 447.52 ms 69.56 ms
0bd723b 395.44 ms 472.66 ms 77.22 ms
1f3652d 367.21 ms 438.46 ms 71.25 ms
e6ffd7b 379.52 ms 449.30 ms 69.78 ms
b172d4e 352.92 ms 446.50 ms 93.58 ms
4e260b3 384.08 ms 477.56 ms 93.48 ms
b172d4e 413.47 ms 479.02 ms 65.55 ms
c7e2fbc 372.00 ms 461.71 ms 89.71 ms
0bd723b 375.20 ms 452.41 ms 77.20 ms
93a76ca 378.48 ms 451.78 ms 73.30 ms

App size

Revision Plain With Sentry Diff
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
1f3652d 1.72 MiB 2.27 MiB 554.95 KiB
e6ffd7b 1.72 MiB 2.29 MiB 579.13 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
4e260b3 1.72 MiB 2.27 MiB 554.95 KiB
b172d4e 1.72 MiB 2.29 MiB 578.09 KiB
c7e2fbc 1.72 MiB 2.29 MiB 576.40 KiB
0bd723b 1.72 MiB 2.29 MiB 578.09 KiB
93a76ca 1.72 MiB 2.29 MiB 576.75 KiB

Previous results on branch: feat/activity-lifecycle-breadcrumbs

Startup times

Revision Plain With Sentry Diff
2c5c35b 412.68 ms 432.88 ms 20.20 ms
0a2dfcd 371.35 ms 456.63 ms 85.29 ms
8052876 400.51 ms 472.53 ms 72.02 ms

App size

Revision Plain With Sentry Diff
2c5c35b 1.72 MiB 2.27 MiB 557.08 KiB
0a2dfcd 1.72 MiB 2.29 MiB 580.76 KiB
8052876 1.72 MiB 2.27 MiB 557.45 KiB

@markushi markushi self-assigned this Nov 29, 2023
addBreadcrumb(activity, "started");
}

@SuppressLint("NewApi")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
@SuppressLint("NewApi")

probably copy-pasta?

Copy link
Member

@romtsn romtsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally splitting this monster up 🚀

Base automatically changed from feat/app-start-spans to main December 13, 2023 12:14
@markushi markushi merged commit 8ccdc9b into main Dec 18, 2023
19 checks passed
@markushi markushi deleted the feat/activity-lifecycle-breadcrumbs branch December 18, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants